Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use preinstall 0.18 in upgrade tests #3927

Merged
merged 3 commits into from
Aug 27, 2020
Merged

Use preinstall 0.18 in upgrade tests #3927

merged 3 commits into from
Aug 27, 2020

Conversation

aliok
Copy link
Member

@aliok aliok commented Aug 25, 2020 •
edited
Loading

Fixes #

Proposed Changes

  • Use preinstall 0.18 script in upgrade tests
  • So, the migration job actually runs (from 0.17 to 0.18) for resources that have a storage version change
  • Some storage version change PRs are already merged without testing
  • Some are still open (like Change storage to v1 for subscriptions #3936) and merging this PR will make sure the storage change PRs are tested properly

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 25, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 25, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Aug 25, 2020
@nlopezgi
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2020
@aliok
Copy link
Member Author

aliok commented Aug 25, 2020

/test pull-knative-eventing-upgrade-tests

Let me try again before digging... Not sure what the error is

@aliok
Copy link
Member Author

aliok commented Aug 26, 2020

Ok, this fails consistently, gonna check it. ...soon

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2020
@aliok
Copy link
Member Author

aliok commented Aug 26, 2020

Found the problem. Should be fixed now. Let's see

@vaikas
Copy link
Contributor

vaikas commented Aug 26, 2020

Looks like the storage migration did not complete:

customresourcedefinition.apiextensions.k8s.io/triggers.eventing.knative.dev configured
Waiting until all batch jobs in namespace knative-eventing-q3b8jw1pn0 run to completion.......................................................................................................................................................
ERROR: timeout waiting for jobs to complete
storage-version-migration-eventing   1     <none>

@aliok aliok force-pushed the use-preinstall-18-in-tests branch from e043b96 to b6d8ecc Compare August 27, 2020 07:49
@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-conformance-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-conformance-tests:

test/conformance.TestBrokerV1Beta1DataPlaneConsumer

@aliok
Copy link
Member Author

aliok commented Aug 27, 2020

/retest

@aliok
Copy link
Member Author

aliok commented Aug 27, 2020

ApiGroups for some resources were wrong in the job config.

All green now!

matzew
matzew approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

aliok
aliok commented Aug 27, 2020
View reviewed changes
config/pre-install/v0.18.0/storage-version-migration.yaml
Comment on lines -41 to +44
- "containersources.eventing.knative.dev"
- "containersources.sources.knative.dev"
- "sinkbindings.sources.knative.dev"
- "brokers.sources.knative.dev"
- "triggers.sources.knative.dev"
- "brokers.eventing.knative.dev"
- "triggers.eventing.knative.dev"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are problems I found when trying to make the migration test working.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2020
@aliok aliok changed the title Use preinstall 0.18 in tests Use preinstall 0.18 in upgrade tests Aug 27, 2020
@knative-prow-robot knative-prow-robot merged commit 30ad3ac into knative:master Aug 27, 2020
@aliok aliok deleted the use-preinstall-18-in-tests branch August 27, 2020 10:07
@nlopezgi nlopezgi mentioned this pull request Sep 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@steuhs steuhs Awaiting requested review from steuhs

Assignees

@matzew matzew

@nlopezgi nlopezgi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aliok @nlopezgi @vaikas @knative-test-reporter-robot @knative-prow-robot @matzew @googlebot